[libcxx-commits] [PATCH] D89948: [libcxx] [test] Ifdef out uses of create_fifo on windows

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo added inline comments.


================
Comment at: libcxx/test/std/input.output/filesystems/class.directory_entry/directory_entry.obs/hard_link_count.pass.cpp:94
 
-  for (auto p : {dir2, fifo, sym_to_fifo}) {
+  for (auto p : {
+    dir2,
----------------
ldionne wrote:
> As a general pattern, could we instead refactor the body of the loop (which contains the actual tests) into a lambda, and then call it with the appropriate inputs? I think that might make the `#ifdefs` less awkward. WDYT?
> 
> I don't think it makes sense to do that everywhere, but I think it might here.
Sounds good, I'll give that a try later and come back to this patch.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89948/new/

https://reviews.llvm.org/D89948