[libcxx-commits] [PATCH] D97084: [libcxx] Make path::format a non-class enum

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

I think they certainly missed an opportunity to make it an `enum class`, but you seem to be right.

Ship it with the comment removed.



================
Comment at: libcxx/test/std/input.output/filesystems/fs.enum/enum.path.format.pass.cpp:26
 
   // Check that E is a scoped enum by checking for conversions.
   typedef std::underlying_type<E>::type UT;
----------------
I don't think this comment applies anymore.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97084/new/

https://reviews.llvm.org/D97084