[libcxx-commits] [PATCH] D62454: SFINAE on pair/tuple assignment operators 2729

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

In D62454#2575490 <https://reviews.llvm.org/D62454#2575490>, @zoecarver wrote:

> @ldionne sorry about that. I don't know how I overlooked the majority of the issue. Anyway, I've made sure that all the overloads have a test now.

Meh, no worries! Thanks a lot for adding the missing tests.

Shiiiiip it!



================
Comment at: libcxx/test/std/utilities/tuple/tuple.tuple/tuple.assign/move.pass.cpp:108
     {
-        using T = std::tuple<int, NonAssignable>;
-        static_assert(!std::is_move_assignable<T>::value, "");
+      // HERE (and below/above)
+      using T = std::tuple<int, NonAssignable>;
----------------
zoecarver wrote:
> This is just to mark where we have existing test coverage for this issue (to make it easier to review). I'll remove these comments when I commit. 
Oh, ok, thanks a lot :-).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62454/new/

https://reviews.llvm.org/D62454