[libcxx-commits] [PATCH] D97083: [libcxx] [test] Remove two unnecesary files/variables in a test

Martin Storsjö via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Feb 19 13:14:05 PST 2021

mstorsjo created this revision.
mstorsjo added reviewers: ldionne, curdeius, libc++.
mstorsjo requested review of this revision.
Herald added a project: libc++.
Herald added 1 blocking reviewer(s): libc++.

These don't seem to have any function in the test.

The non_regular_file one seems to have been added in 0f8c8f59df057a85d6d49913ec9877c6d597785b, without any apparent purpose there.

  rG LLVM Github Monorepo



Index: libcxx/test/std/input.output/filesystems/fs.op.funcs/fs.op.copy_file/copy_file.pass.cpp
--- libcxx/test/std/input.output/filesystems/fs.op.funcs/fs.op.copy_file/copy_file.pass.cpp
+++ libcxx/test/std/input.output/filesystems/fs.op.funcs/fs.op.copy_file/copy_file.pass.cpp
@@ -53,8 +53,6 @@
   scoped_test_env env;
   const path file = env.create_file("file1", 42);
   const path file2 = env.create_file("file2", 55);
-  const path non_regular_file = env.create_fifo("non_reg");
-  const path dne = env.make_env_path("dne");
   { // exists(to) && equivalent(to, from)
     std::error_code ec;

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D97083.325077.patch
Type: text/x-patch
Size: 669 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20210219/bedeb806/attachment-0001.bin>

More information about the libcxx-commits mailing list