[libcxx-commits] [PATCH] D81414: [libcxx] Fix LWG 2875: shared_ptr::shared_ptr(Y*, D, […]) constructors should be constrained.
Zoe Carver via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Thu Feb 18 21:53:38 PST 2021
zoecarver added inline comments.
Comment at: libcxx/test/libcxx/utilities/memory/util.smartptr/util.smartptr.shared/function_type_default_deleter.fail.cpp:42
SPtr<0> s; // OK
SPtr<1> s1(nullptr); // OK
> I think I'm going to remove this test and replace it with a test that just checks we hit a static_assert when instantiating default_delete with a function type; no need to get shared_ptr involved.
Actually, never mind. I just removed shared_ptr from the part that was failing (because it added extra errors because a shared_ptr couldn't be constructed because it SFINAEed out). I think the other parts of this test are actually good to have. Anyway, hopefully that fixes the CI.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the libcxx-commits