[libcxx-commits] [PATCH] D96986: [libc++] Drop template layer when using vsnprintf

[Joerg Sonnenberger via Phabricator via libcxx-commits]

joerg created this revision.
joerg requested review of this revision.
Herald added a project: libc++.
Herald added a subscriber: libcxx-commits.
Herald added a reviewer: libc++.

The filesystem implementation used variadic templates to convert path
arguments to C strings, but in the process, format string checks for
vsnprintf was lost. The latter is more useful than the former, so prefer
the simpler code. While here, fix a small bug in the va_list handling as
the initial list could be va_end'd twice, once by the second vsnprintf
and another time by the guard itself.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D96986

Files:
  libcxx/include/__config
  libcxx/src/filesystem/directory_iterator.cpp
  libcxx/src/filesystem/filesystem_common.h
  libcxx/src/filesystem/operations.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D96986.324730.patch
Type: text/x-patch
Size: 5328 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20210218/860bf907/attachment.bin>