[libcxx-commits] [PATCH] D96966: [libc++] Remove temporary stack-allocated array

[Dominic Chen via Phabricator via libcxx-commits]

ddcc created this revision.
ddcc added reviewers: ldionne, curdeius, EricWF.
ddcc requested review of this revision.
Herald added a project: libc++.
Herald added a reviewer: libc++.

Manual inspection of generated IR shows temporary stack allocation


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D96966

Files:
  libcxx/include/string


Index: libcxx/include/string
===================================================================
--- libcxx/include/string
+++ libcxx/include/string
@@ -1558,9 +1558,8 @@
     _LIBCPP_INLINE_VISIBILITY
     void __zero() _NOEXCEPT
         {
-            size_type (&__a)[__n_words] = __r_.first().__r.__words;
             for (unsigned __i = 0; __i < __n_words; ++__i)
-                __a[__i] = 0;
+                __r_.first().__r.__words[__i] = 0;
         }
 
     template <size_type __a> static


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D96966.324659.patch
Type: text/x-patch
Size: 504 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20210218/8f48fa9e/attachment.bin>