[libcxx-commits] [PATCH] D81414: [libcxx] Fix LWG 2875: shared_ptr::shared_ptr(Y*, D, […]) constructors should be constrained.
Zoe Carver via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Wed Feb 17 20:58:14 PST 2021
zoecarver added a comment.
> LGTM. I assume the array part of the requirements in https://wg21.link/LWG2875 are handled in your arrays-in-shared-ptr patch (which I need to get back to reviewing)?
I don't think the wording changes anything about how arrays are handled. As I understand it the deleter requirements are the same for array types and non-array types. Also, the arrays-in-shared-ptr patch landed: D62259 <https://reviews.llvm.org/D62259>. A shared_ptr with array types still uses the same overload, that's what the `__compatible_with` trait is in charge of.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the libcxx-commits