[libcxx-commits] [PATCH] D96901: [libunwind] Add support for PC reg column in arm64

[Marco Vanotti via Phabricator via libcxx-commits]

charco added a comment.

In D96901#2570338 <https://reviews.llvm.org/D96901#2570338>, @charco wrote:

> In D96901#2570327 <https://reviews.llvm.org/D96901#2570327>, @joerg wrote:
>
>> Registers_arm64::jumpto in UnwindRegistersRestore.S.
>
> Isn't that code filling x30 with the `__pc` register?
>
> Line 587 says: `  ldr    x30,     [x0, #0x100]  // restore pc into lr`
>
> And offset #0x100 is `__pc`

Ah, but we are not restoring the x30 register.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96901/new/

https://reviews.llvm.org/D96901