[libcxx-commits] [PATCH] D96523: [libc++] Rewrite the tuple constructors to be strictly Standards conforming

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

In D96523#2566936 <https://reviews.llvm.org/D96523#2566936>, @zoecarver wrote:

> [...]
>
> Hmm. I understand what you're saying, but I think that's only the case if it's a static var. If it's actually part of the type (i.e., it's used to specialize a `_BoolConstant`), I think it works the same way. Here's an example. <https://godbolt.org/z/Mdd5s1>

Your example is broken - it SFINAEs out because you're zipping parameter packs of different lengths. See https://godbolt.org/z/qna759.

In D96523#2567168 <https://reviews.llvm.org/D96523#2567168>, @smeenai wrote:

> Will this fix https://bugs.llvm.org/show_bug.cgi?id=17550?

Nope, but that's fixed by the parent patch https://reviews.llvm.org/D50106.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96523/new/

https://reviews.llvm.org/D96523