[libcxx-commits] [PATCH] D96577: [libcxx] adds concept `std::uniform_random_bit_generator`
Louis Dionne via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Wed Feb 17 14:28:43 PST 2021
ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.
LGTM apart for the nitpick. Let's settle on what we do about it and ship this.
Comment at: libcxx/include/random:1704
+#if _LIBCPP_STD_VER > 17 && defined(__cpp_concepts) && __cpp_concepts >= 201811L
> in https://reviews.llvm.org/D93166 we have a definition of _LIBCPP_HAS_NO_CONCEPTS
> Should we reuse that globally and why are there different values ofr the macro?
> why are there different values ofr the macro?
I don't know. @cjdb do you know what `201907L` vs `201811L` represents for `__cpp_concepts`?
> Should we reuse that globally
Depending to the answer to the question above, I think it would make sense to use `#if _LIBCPP_STD_VER > 17 && !defined(_LIBCPP_HAS_NO_CONCEPTS)`.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the libcxx-commits