[libcxx-commits] [PATCH] D96842: [dfsan] Do not specialize vector<bool> for DFSan

stephan.yichao.zhao via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Feb 17 14:12:39 PST 2021


stephan.yichao.zhao added a comment.

In D96842#2569694 <https://reviews.llvm.org/D96842#2569694>, @eugenis wrote:

>> Can we keep all interfaces unchanged, and add some DFSan logic inside a method when the sanitizer is used?
>
> This sounds like an acceptable solution.
>
> To double check my understanding, you are proposing vector<bool> owns a small shadow for its contents (2 bytes per bit!) internally, and, for example, implementation of operator[] would copy the right label to its output.

Yup. This will be adding more code but not be changing interfaces... I need to try, and see how the change would look like.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96842/new/

https://reviews.llvm.org/D96842



More information about the libcxx-commits mailing list