[libcxx-commits] [PATCH] D91178: [22/N] [libcxx] Implement append and operator/ properly for windows

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo added inline comments.


================
Comment at: libcxx/include/filesystem:1092
     using _CVT = _PathCVT<_ItVal>;
     if (__first != __last && __source_is_absolute(*__first))
       __pn_.clear();
----------------
This case of `__source_is_absolute()` is trickier - I think? If we break it out into a separate `bool __source_is_absolute`, it'd be invoked even if `__first == __last`. (I'm not sure if that's ok or not.) Or we could just go without the extra intermediate variable there?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91178/new/

https://reviews.llvm.org/D91178