[libcxx-commits] [PATCH] D96560: libunwind: Don't attempt to authenticate a null return address.

Peter Collingbourne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Feb 16 11:18:24 PST 2021


This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGcddc53ef088b: libunwind: Don't attempt to authenticate a null return address. (authored by pcc).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96560/new/

https://reviews.llvm.org/D96560

Files:
  libunwind/src/DwarfInstructions.hpp


Index: libunwind/src/DwarfInstructions.hpp
===================================================================
--- libunwind/src/DwarfInstructions.hpp
+++ libunwind/src/DwarfInstructions.hpp
@@ -213,7 +213,8 @@
       // restored. autia1716 is used instead of autia as autia1716 assembles
       // to a NOP on pre-v8.3a architectures.
       if ((R::getArch() == REGISTERS_ARM64) &&
-          prolog.savedRegisters[UNW_ARM64_RA_SIGN_STATE].value) {
+          prolog.savedRegisters[UNW_ARM64_RA_SIGN_STATE].value &&
+          returnAddress != 0) {
 #if !defined(_LIBUNWIND_IS_NATIVE_ONLY)
         return UNW_ECROSSRASIGNING;
 #else


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D96560.324061.patch
Type: text/x-patch
Size: 636 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20210216/bc97596a/attachment.bin>


More information about the libcxx-commits mailing list