[libcxx-commits] [PATCH] D96786: <ciso646> should provide defines for alternative operator representations

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

In D96786#2566105 <https://reviews.llvm.org/D96786#2566105>, @georgthegreat wrote:

> I have digged through C++ Working Draft and found the following:
>
> [...]
>
> This makes me think that it maybe better to generate `#error` instead of trying to workaround MSVC problem.
>
> @mclow.lists, @ldionne, what do you think?

I don't think we can `#error` out (or remove those headers, which would be equivalent) because we still need to support previous Standards. In C++03, for example, `<ciso646>` is a valid header, and although code should not use it, someone would be in their right to file a bug against our C++03  conformance if we didn't provide it.

I 100% agree in spirit that we should remove these headers, though. Just not in practice.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96786/new/

https://reviews.llvm.org/D96786