[libcxx-commits] [PATCH] D96786: <ciso646> should provide defines for alternative operator representations

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Feb 16 07:12:08 PST 2021

ldionne requested changes to this revision.
ldionne added a comment.
This revision now requires changes to proceed.

In D96786#2565638 <https://reviews.llvm.org/D96786#2565638>, @mclow.lists wrote:

> That  cppreference page you quote says:
>> The same words are defined in the C programming language in the include file <iso646.h> as macros. Because in C++ these are built into the language, the C++ version of <iso646.h>, as well as <ciso646>, does not define anything.

I agree with Marshall. I think the better approach here would be to file a bug against MSVC and ask them why they do not define the alternate operator representations as keywords in their compiler. If there's a good reason, we could go with your patch because it doesn't cost us much.

  rG LLVM Github Monorepo



More information about the libcxx-commits mailing list