[libcxx-commits] [PATCH] D96786: <ciso646> should provide defines for alternative operator representations

Yuriy Chernyshov via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Feb 16 06:59:36 PST 2021


georgthegreat created this revision.
georgthegreat added a reviewer: ldionne.
georgthegreat requested review of this revision.
Herald added a project: libc++.
Herald added a subscriber: libcxx-commits.
Herald added a reviewer: libc++.

MSVC does not provide builtin support for alternative operator representations <https://en.cppreference.com/w/cpp/language/operator_alternative>.

Instead, their `#include <сiso646>` includes <https://github.com/microsoft/STL/blob/main/stl/inc/ciso646> `iso646.h`, which contains preprocessor definitions for these terms.

Generally, people, even LLVM project itself <https://github.com/llvm/llvm-project/blob/main/llvm/lib/DebugInfo/GSYM/LookupResult.cpp> do not expect their code to be compiled agains libcxx on Windows. This PR makes `#include <ciso646>` and `#include <iso646.h>` equavalent.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D96786

Files:
  libcxx/include/ciso646


Index: libcxx/include/ciso646
===================================================================
--- libcxx/include/ciso646
+++ libcxx/include/ciso646
@@ -16,9 +16,10 @@
 */

 #include <__config>
+#include <iso646.h>

 #if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER)
 #pragma GCC system_header
 #endif

 #endif  // _LIBCPP_CISO646


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D96786.323996.patch
Type: text/x-patch
Size: 334 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20210216/6f758b84/attachment.bin>


More information about the libcxx-commits mailing list