[libcxx-commits] [PATCH] D96385: [libc++] [P1032] Finish constexpr-ifying <iterator>, <string_view>, <tuple>, <utility>.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne requested changes to this revision.
ldionne added a comment.
This revision now requires changes to proceed.

Thanks for the heads up about `__cpp_lib_constexpr_memory`, fixed in 5d0d465ad4d25398519b85879d61fc126abd641c <https://reviews.llvm.org/rG5d0d465ad4d25398519b85879d61fc126abd641c>.

This is great, it's only missing some more tests. I don't foresee any additional issues given the appropriate tests.



================
Comment at: libcxx/include/chrono:2311
 {
-    static_assert(std::numeric_limits<unsigned>::digits >= 18, "");
-    static_assert(std::numeric_limits<int>::digits >= 20     , "");
+    static_assert(numeric_limits<unsigned>::digits >= 18, "");
+    static_assert(numeric_limits<int>::digits >= 20     , "");
----------------
Those changes are orthogonal to the patch, could you please remove them (and commit them separately without review if you want, I don't mind).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96385/new/

https://reviews.llvm.org/D96385