[libcxx-commits] [PATCH] D96720: Define new/delete in libc++ when using libcxxrt

[Alexander Richardson via Phabricator via libcxx-commits]

arichardson added a comment.

In D96720#2563989 <https://reviews.llvm.org/D96720#2563989>, @ldionne wrote:

> Is the 12.x release fixed, or does this patch need to be cherry-picked to the branch?
>
> Would you be willing to add a CI job using FreeBSD?

That would be great. However, there are currently some failing tests which should probably be XFAILed with a tracking bug report:
Here's the list of currently failing tests on FreeBSD 12.2:

  Failed Tests (25):
    libc++ :: libcxx/gdb/gdb_pretty_printer_test.sh.cpp
    libc++ :: std/localization/locale.categories/category.collate/locale.collate.byname/compare.pass.cpp
    libc++ :: std/localization/locale.categories/category.monetary/locale.money.get/locale.money.get.members/get_long_double_ru_RU.pass.cpp
    libc++ :: std/localization/locale.categories/category.monetary/locale.money.get/locale.money.get.members/get_long_double_zh_CN.pass.cpp
    libc++ :: std/localization/locale.categories/category.monetary/locale.money.put/locale.money.put.members/put_long_double_ru_RU.pass.cpp
    libc++ :: std/localization/locale.categories/category.monetary/locale.money.put/locale.money.put.members/put_long_double_zh_CN.pass.cpp
    libc++ :: std/localization/locale.categories/category.monetary/locale.moneypunct.byname/curr_symbol.pass.cpp
    libc++ :: std/localization/locale.categories/category.monetary/locale.moneypunct.byname/grouping.pass.cpp
    libc++ :: std/localization/locale.categories/category.monetary/locale.moneypunct.byname/neg_format.pass.cpp
    libc++ :: std/localization/locale.categories/category.monetary/locale.moneypunct.byname/pos_format.pass.cpp
    libc++ :: std/localization/locale.categories/category.monetary/locale.moneypunct.byname/thousands_sep.pass.cpp
    libc++ :: std/localization/locale.categories/category.time/locale.time.get.byname/get_monthname.pass.cpp
    libc++ :: std/localization/locale.categories/category.time/locale.time.get.byname/get_monthname_wide.pass.cpp
    libc++ :: std/localization/locale.categories/category.time/locale.time.get.byname/get_one.pass.cpp
    libc++ :: std/localization/locale.categories/category.time/locale.time.get.byname/get_one_wide.pass.cpp
    libc++ :: std/localization/locale.categories/category.time/locale.time.put.byname/put1.pass.cpp
    libc++ :: std/localization/locale.categories/facet.numpunct/locale.numpunct.byname/grouping.pass.cpp
    libc++ :: std/localization/locale.categories/facet.numpunct/locale.numpunct.byname/thousands_sep.pass.cpp
    libc++ :: std/re/re.traits/lookup_collatename.pass.cpp
    libc++ :: std/re/re.traits/transform_primary.pass.cpp
    libc++ :: std/thread/thread.mutex/thread.mutex.requirements/thread.sharedtimedmutex.requirements/thread.sharedtimedmutex.class/try_lock_shared_for.pass.cpp
    libc++abi :: thread_local_destruction_order.pass.cpp
    libunwind :: libunwind_01.pass.cpp
    libunwind :: signal_frame.pass.cpp
    libunwind :: unw_getcontext.pass.cpp

I've tried to fix some of them, but the locale tests are quite awkward to debug and determine what the correct behaviour should be.
I think thread.sharedtimedmutex.class/try_lock_shared_for.pass.cpp may be be a flaky failure (I believe it usually passes) since I was running it on a system with high CPU load.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96720/new/

https://reviews.llvm.org/D96720