[libcxx-commits] [PATCH] D96660: [libcxx] adds concept `std::common_reference_with`

Christopher Di Bella via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Sun Feb 14 11:43:26 PST 2021


cjdb marked an inline comment as done.
cjdb added inline comments.


================
Comment at: libcxx/include/concepts:181
+  convertible_to<_Tp, common_reference_t<_Tp, _Up>> &&
+  convertible_to<_Up, common_reference_t<_Up, _Tp>>;
+
----------------
Mordante wrote:
> I know it behaves the same, but is there a reason you use `common_reference_t<_Up, _Tp>` instead of `common_reference_t<_Tp, _Up>` as specified in the standard?
I think this was a late night change from `common_reference_t<_Up, _Up>`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96660/new/

https://reviews.llvm.org/D96660



More information about the libcxx-commits mailing list