[libcxx-commits] [PATCH] D96577: [libcxx] adds concept `std::uniform_random_bit_generator`

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Sun Feb 14 06:10:12 PST 2021


Mordante added a comment.

In D96577#2562047 <https://reviews.llvm.org/D96577#2562047>, @cjdb wrote:

>> Yes there seems to be a bug in that code. I've put it in a block for GCC specific code. (This is not obvious due to the lack of indention of the section.)
>
> Oh, it might be because Clang's concepts are incomplete and so the feature-test macro's value is too high for us? Anyway, if you update everything in one fell swoop, I think that'd be best :-)

No it was the placement in the file. But I'll fix `<random>` and `<concept>` after the fix has landed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96577/new/

https://reviews.llvm.org/D96577



More information about the libcxx-commits mailing list