[libcxx-commits] [PATCH] D96577: [libcxx] adds concept `std::uniform_random_bit_generator`

[Michael Schellenberger Costa via Phabricator via libcxx-commits]

miscco added a comment.

Thanks for working on this. It is missing uglification but besides that I only have one small nit



================
Comment at: libcxx/include/random:1707
+// [rand.req.urng]
+template<class G>
+concept uniform_random_bit_generator =
----------------
This should be `_Ugly`, maybe use `_Gen`?


================
Comment at: libcxx/test/std/numerics/rand/rand.req/rand.req.urng/uniform_random_bit_generator.compile.pass.cpp:118
+
+  static constexpr unsigned char min() { return ~0; }
+  static constexpr unsigned char max() { return 0; }
----------------
I think that 1 and 0 would be more obvious that ~0 and 0


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96577/new/

https://reviews.llvm.org/D96577