[libcxx-commits] [PATCH] D96477: [libcxx] adds remaining callable concepts

[Christopher Di Bella via Phabricator via libcxx-commits]

cjdb marked 2 inline comments as done.
cjdb added inline comments.


================
Comment at: libcxx/test/std/concepts/callable/functions.h:8
 //===----------------------------------------------------------------------===//
-#ifndef CALLABLE_FUNCTIONS_H
-#define CALLABLE_FUNCTIONS_H
+#ifndef TEST_STD_CONCEPTS_LAND_CALLABLE_FUNCTIONS_H
+#define TEST_STD_CONCEPTS_LAND_CALLABLE_FUNCTIONS_H
----------------
curdeius wrote:
> cjdb wrote:
> > curdeius wrote:
> > > `LAND_` should be removed, nope?
> > See @ldionne's request in D96230.
> You mean this https://reviews.llvm.org/D96230#inline-902629? There was "lang" in the path and a typo in the guard macro.
Ah, good point. I'll fix both up, but won't commit since it's not worth impacting CI times for more important patches.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96477/new/

https://reviews.llvm.org/D96477