[libcxx-commits] [PATCH] D96235: [libcxx] adds concepts `std::invocable` and `std::regular_invocable`

Christopher Di Bella via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Feb 10 11:07:28 PST 2021


cjdb marked an inline comment as not done.
cjdb added inline comments.


================
Comment at: libcxx/include/concepts:187-189
+// [concept.regular.invocable]
+template<class _Fn, class... _Args>
+concept regular_invocable = invocable<_Fn, _Args...>;
----------------
The difference between `invocable` and `regular_invocable` is purely semantic. Do we want do add any sort of documentation here to indicate as much?


================
Comment at: libcxx/test/std/concepts/callable/invocable.pass.cpp:110
+  {
+    auto G = std::mt19937_64(std::random_device()());
+    auto D = std::uniform_int_distribution<>();
----------------
Mordante wrote:
> Can you initialize it with something different, this seems to cause a build failure when the platform has no random device.
Yes, but I'm going to open a bug, because I think 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96235/new/

https://reviews.llvm.org/D96235



More information about the libcxx-commits mailing list