[libcxx-commits] [PATCH] D96378: [libc++abi] Fix forced_unwind tests failures on ARM/EHABI targets.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

In D96378#2554606 <https://reviews.llvm.org/D96378#2554606>, @MaskRay wrote:

> The `int main() {}` change is unnecessary but I don't know the libc++ specific code style well.
>
> You still need an owner's approval.

LGTM except the nitpick about how `main()` is declared. When testing under freestanding mode, `main` isn't considered special. It needs to be declared as `int main(int, char**)` so it mangles the right way and we can call it explicitly from the test harness. It's kind of nitpicky.



================
Comment at: libcxxabi/test/forced_unwind1.pass.cpp:21
 #if defined(_LIBCXXABI_ARM_EHABI)
-int main() {}
+int main() {
+  return 0;
----------------
Can you use `int main(int, char**)`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96378/new/

https://reviews.llvm.org/D96378