[libcxx-commits] [PATCH] D96232: [libcxx] adds concept `std::copy_constructible`

[Christopher Di Bella via Phabricator via libcxx-commits]

cjdb added inline comments.


================
Comment at: libcxx/test/std/concepts/lang/copyconstructible.compile.pass.cpp:21
+
+// Tests in this namespace are common with moveconstructible.pass.cpp
+// There are some interesting differences, so it's best if they're tested here
----------------
ldionne wrote:
> cjdb wrote:
> > ldionne wrote:
> > > I'm not sure I follow that comment, but it's non-blocking.
> > Does `s/common/shared/` make it a little clearer?
> Ah, I looked at the rev for `move_constructible` and I understand better. Feel free to change the comment or not.
> 
> If we have to duplicate this list of types in a bunch of places, we should consider storing it in a single place with a way to reuse it across tests.
I'd like to do that, but it's not feasible without macros (concepts can't be template parameters). Your call here, but I'm... not in favour of that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96232/new/

https://reviews.llvm.org/D96232