[libcxx-commits] [PATCH] D96232: [libcxx] adds concept `std::copy_constructible`

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added inline comments.


================
Comment at: libcxx/test/std/concepts/lang/copyconstructible.compile.pass.cpp:21
+
+// Tests in this namespace are common with moveconstructible.pass.cpp
+// There are some interesting differences, so it's best if they're tested here
----------------
cjdb wrote:
> ldionne wrote:
> > I'm not sure I follow that comment, but it's non-blocking.
> Does `s/common/shared/` make it a little clearer?
Ah, I looked at the rev for `move_constructible` and I understand better. Feel free to change the comment or not.

If we have to duplicate this list of types in a bunch of places, we should consider storing it in a single place with a way to reuse it across tests.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96232/new/

https://reviews.llvm.org/D96232