[libcxx-commits] [PATCH] D96232: [libcxx] adds concept `std::copy_constructible`
Louis Dionne via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Wed Feb 10 08:46:18 PST 2021
ldionne accepted this revision.
ldionne added inline comments.
Comment at: libcxx/test/std/concepts/lang/copyconstructible.compile.pass.cpp:21
+// Tests in this namespace are common with moveconstructible.pass.cpp
+// There are some interesting differences, so it's best if they're tested here
> ldionne wrote:
> > I'm not sure I follow that comment, but it's non-blocking.
> Does `s/common/shared/` make it a little clearer?
Ah, I looked at the rev for `move_constructible` and I understand better. Feel free to change the comment or not.
If we have to duplicate this list of types in a bunch of places, we should consider storing it in a single place with a way to reuse it across tests.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the libcxx-commits