[libcxx-commits] [PATCH] D96385: [libc++] [P1032] Misc constexpr bits in <iterator>

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Feb 10 08:15:57 PST 2021


ldionne requested changes to this revision.
ldionne added a comment.
This revision now requires changes to proceed.

Confirmed with Arthur that we're still missing some `constexpr`-ification in `tuple`, so we shouldn't mark the paper as implemented here. However, how about we add the missing constexprification in `tuple` in this patch?

Also, this is missing `constexpr` tests for all the iterators. We should write a dummy `constexpr` container to test those.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96385/new/

https://reviews.llvm.org/D96385



More information about the libcxx-commits mailing list