[libcxx-commits] [PATCH] D96408: Fix warnings when compiling libcxx for Windows with clang-cl /W4

Colin Finck via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Feb 10 04:37:20 PST 2021

ColinFinck created this revision.
ColinFinck added a reviewer: libc++.
ColinFinck added a project: libc++.
ColinFinck requested review of this revision.
Herald added a subscriber: libcxx-commits.
Herald added 1 blocking reviewer(s): libc++.

Only these two unused variables left, then it's perfect.

`Colin Finck <colin at reactos.org>`

  rG LLVM Github Monorepo



Index: libcxx/src/support/win32/locale_win32.cpp
--- libcxx/src/support/win32/locale_win32.cpp
+++ libcxx/src/support/win32/locale_win32.cpp
@@ -19,6 +19,7 @@
 // FIXME: base currently unused. Needs manual work to construct the new locale
 locale_t newlocale( int mask, const char * locale, locale_t /*base*/ )
+    (void)mask;
     return {_create_locale( LC_ALL, locale ), locale};
Index: libcxx/src/atomic.cpp
--- libcxx/src/atomic.cpp
+++ libcxx/src/atomic.cpp
@@ -121,6 +121,7 @@
                                                                __cxx_atomic_contention_t const volatile* __platform_state)
     // We will monitor this value.
+    (void)__contention_state;
     return __cxx_atomic_load(__platform_state, memory_order_acquire);
 static void __libcpp_contention_wait(__cxx_atomic_contention_t volatile* __contention_state,

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D96408.322650.patch
Type: text/x-patch
Size: 991 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20210210/fb0ceb8e/attachment.bin>

More information about the libcxx-commits mailing list