[libcxx-commits] [PATCH] D96339: Build thread_win32.cpp only if LIBCXX_HAS_PTHREAD_API is not set.

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo added a comment.

The change looks fine to me (although I didn't try it myself - and with the additional request to add another condition to it), but someone else has to approve it as well. Can you provide your desired git author string (`Full Name <email at domain>`) to be used when it would be applied?



================
Comment at: libcxx/src/CMakeLists.txt:82
+
+  if (NOT LIBCXX_HAS_PTHREAD_API)
+    list(APPEND LIBCXX_SOURCES
----------------
This is the cmake define for when pthread api is explicitly forced to be used, instead of autodetection based on platform and `__has_include(<pthread.h>)` and such - right? In that case I guess it's ok.

There's also been a desire (in https://reviews.llvm.org/D88124#change-1LdJXjC8YEPj) to make compilation of this file optional based on `LIBCXX_ENABLE_THREADS` - I guess it'd be nice to do that at the same time while adding conditionals here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96339/new/

https://reviews.llvm.org/D96339