[libcxx-commits] [PATCH] D93593: [libc++][format] Add __format_arg_store.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added inline comments.


================
Comment at: libcxx/include/format:223
+// to support compilers with partial C++20 support.
+#ifndef _LIBCPP_HAS_NO_CONCEPTS
+
----------------
Mordante wrote:
> @ldionne If you agree with this approach I'll move it to D93166, which then should fix the issues @mehdi_amini has using clang 8.
Ok, but please add a fat `TODO` here.

It's now my #1 priority to bump the compiler requirements for building libc++. It just doesn't make sense to try to build a C++20 library with a compiler that doesn't support C++20. The resulting library will be broken. Plus we've been accumulating serious debt lately due to this outdated policy.

For now make sure it works with Clang 8, but I'll kick this off on llvm-dev and the other lists.

@mehdi_amini  You should move to building libc++ with the runtimes build (i.e. building libc++ with the Clang you just bootstrapped) to avoid issues like this in the future. Building libc++ with Clangs that old is only supported on paper, but I would never do that. I'll work on making the policy meet reality.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93593/new/

https://reviews.llvm.org/D93593