[libcxx-commits] [PATCH] D74292: [libcxx] adds concept std::derived_from

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Feb 9 15:30:55 PST 2021


ldionne requested changes to this revision.
ldionne added inline comments.
This revision now requires changes to proceed.


================
Comment at: libcxx/include/concepts:168
+#else
+  _VSTD::is_convertible_v<const volatile _Dp*, const volatile _Bp*>;
+#endif // __clang__
----------------
I thought I had left a comment here, but I would prefer that we de-duplicate this implementation and unconditionally use `is_convertible_v` (as mentioned on other patches).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74292/new/

https://reviews.llvm.org/D74292



More information about the libcxx-commits mailing list