[libcxx-commits] [PATCH] D77961: [libcxx] adds concept `std::convertible_to`

[Christopher Di Bella via Phabricator via libcxx-commits]

cjdb added a comment.

> More generally, have we looked into the MSVC tests for concepts? Would it make sense to import them here too or at least make sure we have the same coverage?

>From what I've seen, MSVC seems to have one monolithic file for all the concepts, so I think there are two options for us to choose from if we want to include them:

1. Wait till all of [concepts] is implemented, then add the MSVC test file at the root.
2. Split the monolithic file up so it fits in with all of the libc++ tests.

The advantage of approach (1) is that it's fast, and MSVC STL contributors can painlessly update our copy of the test file whenever theirs is also updated.
However, it's a monolithic test suite, and I'm not really keen on that: I prefer my tests to be more fine-grained, but this is more work, meaning we'd lose the convenience of getting MSVC STL updates almost for free.

Which do you prefer?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77961/new/

https://reviews.llvm.org/D77961