[libcxx-commits] [libcxx] 34acc91 - [libc++] Require C++20 to build the benchmarks.

Mark de Wever via libcxx-commits libcxx-commits at lists.llvm.org
Tue Feb 9 09:34:15 PST 2021


Author: Mark de Wever
Date: 2021-02-09T18:34:07+01:00
New Revision: 34acc91642440b8e4bad17acfdbb1314c8f2043e

URL: https://github.com/llvm/llvm-project/commit/34acc91642440b8e4bad17acfdbb1314c8f2043e
DIFF: https://github.com/llvm/llvm-project/commit/34acc91642440b8e4bad17acfdbb1314c8f2043e.diff

LOG: [libc++] Require C++20 to build the benchmarks.

Some work-in-progress patches for the format header contain benchmarks.
The format header requires C++20 to build. This is a preparation to make
it easy to add these benchmarks.

Reviewed By: ldionne, #libc

Differential Revision: https://reviews.llvm.org/D96057

Added: 
    

Modified: 
    libcxx/benchmarks/CMakeLists.txt
    libcxx/docs/ReleaseNotes.rst

Removed: 
    


################################################################################
diff  --git a/libcxx/benchmarks/CMakeLists.txt b/libcxx/benchmarks/CMakeLists.txt
index 0327f05ccfa6..340de8640f04 100644
--- a/libcxx/benchmarks/CMakeLists.txt
+++ b/libcxx/benchmarks/CMakeLists.txt
@@ -142,7 +142,7 @@ function(add_benchmark_test name source_file)
           RUNTIME_OUTPUT_DIRECTORY "${BENCHMARK_OUTPUT_DIR}"
           COMPILE_FLAGS "${BENCHMARK_TEST_LIBCXX_COMPILE_FLAGS}"
           LINK_FLAGS "${BENCHMARK_TEST_LIBCXX_LINK_FLAGS}"
-          CXX_STANDARD 17
+          CXX_STANDARD 20
           CXX_STANDARD_REQUIRED YES
           CXX_EXTENSIONS NO)
   cxx_link_system_libraries(${libcxx_target})
@@ -172,7 +172,7 @@ function(add_benchmark_test name source_file)
           INCLUDE_DIRECTORIES ""
           COMPILE_FLAGS "${BENCHMARK_TEST_NATIVE_COMPILE_FLAGS}"
           LINK_FLAGS "${BENCHMARK_TEST_NATIVE_LINK_FLAGS}"
-          CXX_STANDARD 17
+          CXX_STANDARD 20
           CXX_STANDARD_REQUIRED YES
           CXX_EXTENSIONS NO)
   endif()

diff  --git a/libcxx/docs/ReleaseNotes.rst b/libcxx/docs/ReleaseNotes.rst
index 00ada48ab3d6..d9302fefa954 100644
--- a/libcxx/docs/ReleaseNotes.rst
+++ b/libcxx/docs/ReleaseNotes.rst
@@ -43,4 +43,5 @@ New Features
 API Changes
 -----------
 
-- ...
+- Starting with libc++13 a C++20 capable compiler is required to build the
+  libc++ benchmarks.


        


More information about the libcxx-commits mailing list