[libcxx-commits] [PATCH] D96232: [libcxx] adds concept `std::copy_constructible`

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

Also look at the remarks in D96230 <https://reviews.llvm.org/D96230> that are applicable here.



================
Comment at: libcxx/test/std/concepts/lang/copyconstructible.pass.cpp:12
+
+// template<class From, class To>
+// concept copy_constructible;
----------------
This seems to be a copy-paste. `copy_constructible` has only one template argument.


================
Comment at: libcxx/test/std/concepts/lang/moveconstructible.h:1
+#ifndef MOVECONSTRUCTIBLE_H
+#define MOVECONSTRUCTIBLE_H
----------------
Misses the header block. Would it make sense to implement this header already in D96230?



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96232/new/

https://reviews.llvm.org/D96232