[libcxx-commits] [PATCH] D96230: [libcxx] adds concept `std::move_constructible`

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

Do we need to do some tests on
[concept.moveconstructible]/1 http://eel.is/c++draft/concepts#concept.moveconstructible-1 ? Or does `constructible_­from` and `convertible_­to` guarantee these conditions hold?



================
Comment at: libcxx/test/std/concepts/lang/moveconstructible.pass.cpp:7
+//
+//===----------------------------------------------------------------------===//
+
----------------
Since the tests only has `static_assert`s it could be made a compile-time test. That can be done by renaming the file to `move_constructible.compile.pass.cpp`




================
Comment at: libcxx/test/std/concepts/lang/moveconstructible.pass.cpp:12
+
+// template<class From, class To>
+// concept move_constructible;
----------------
This seems to be a copy-paste.  `move_constructible` has only one template argument.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96230/new/

https://reviews.llvm.org/D96230