[libcxx-commits] [PATCH] D88131: adds [concepts.arithmetic]

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

In D88131#2547168 <https://reviews.llvm.org/D88131#2547168>, @cjdb wrote:

> In D88131#2545799 <https://reviews.llvm.org/D88131#2545799>, @ldionne wrote:
>
>> Are you using `arc diff` to upload patches? The Phab -> BuildKite bridge seems to have trouble applying your patches, not sure why.
>
> No, I've been using the Phab web interface. Do you recommend I try the CLI tool instead?

Without the CLI tool the CI will not automatically rebuild the new diff. This is an issue with Phabricator.



================
Comment at: libcxx/include/concepts:187
+template<class _Tp>
+concept unsigned_integral = integral<_Tp> && !signed_integral<_Tp>;
+
----------------
Interesting to it written like this, it compares `integral<_Tp>` twice. (Just a remark, since this matches the Standard.)


================
Comment at: libcxx/test/std/concepts/lang/arithmetic.pass.cpp:72
+  CheckIntegralQualifiers<long long>();
+  CheckIntegralQualifiers<unsigned long long>();
+
----------------
Can you also test `__int128_t` and `__uint128_t` where applicable? This can be guarded with `#ifndef _LIBCPP_HAS_NO_INT128`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88131/new/

https://reviews.llvm.org/D88131