[libcxx-commits] [PATCH] D96200: [libc++] Remove C++11 work-arounds in src.

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Sat Feb 6 12:22:28 PST 2021


Mordante added a comment.

In D96200#2546962 <https://reviews.llvm.org/D96200#2546962>, @curdeius wrote:

> Isn't it strange that a filesystem test builds the sources with `-std=c++11`? By source here I mean something under `src/`, precisely `libcxx/src/filesystem/filesystem_common.h`.
> It seems like a bad separation between the code and the tests.

I tend to agree, however this test is a libcxx test and not a std test. So I assume that's the reason it's testing the internals.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96200/new/

https://reviews.llvm.org/D96200



More information about the libcxx-commits mailing list