[libcxx-commits] [PATCH] D93542: [SystemZ][ZOS] Provide CLOCK_MONOTONIC alternative

[Zibi Sarbino via Phabricator via libcxx-commits]

zibi added a comment.

Moving to chrono.cpp is fine, otherwise please provide the exact suggestion for `target_compile_definitions()` .



================
Comment at: libcxx/src/CMakeLists.txt:5-10
+if (ZOS)
+  set_source_files_properties(
+    chrono.cpp
+    PROPERTIES COMPILE_DEFINITIONS "_LARGE_TIME_API"
+    )
+endif()
----------------
ldionne wrote:
> ldionne wrote:
> > If we're doing it this way, then why not add a `#define` at the top of `chrono.cpp`? I'd like to avoid adding complexity to the build system.
> So please either use a define in `chrono.cpp` or implement my suggestion of `target_compile_definitions()`, but not this.
> If we're doing it this way, then why not add a `#define` at the top of `chrono.cpp`? I'd like to avoid adding complexity to the build system.




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93542/new/

https://reviews.llvm.org/D93542