[libcxx-commits] [PATCH] D96167: Various minor fixes for python 3

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Feb 5 12:24:58 PST 2021


ldionne accepted this revision.
ldionne added a comment.

In D96167#2545895 <https://reviews.llvm.org/D96167#2545895>, @saugustine wrote:

> In D96167#2545870 <https://reviews.llvm.org/D96167#2545870>, @mgorny wrote:
>
>> I haven't tested it on main but on top of 12.0.0-rc1:
>
>
>
>> /tmp/portage/sys-libs/libcxx-12.0.0_rc1/work/libcxx/test/libcxx/gdb/gdb_pretty_printer_test.sh.cpp:494:20: error: use of undeclared identifier 'R'
>>
>>   "not_found", R "(std::__map_iterator ( = {\[0x[a-f0-9]+\] = .*}|<error "
>>                ^
>>
>> 1 error generated.
>
> That's what I get for trusting the linter that automatically runs at arc diff time. Surely a bug there. I've undone its fix, so we should be good to go.

I always use `arc diff --nolint`. LGTM again once CI is green.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96167/new/

https://reviews.llvm.org/D96167



More information about the libcxx-commits mailing list