[libcxx-commits] [PATCH] D93542: [SystemZ][ZOS] Provide CLOCK_MONOTONIC alternative
Louis Dionne via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Fri Feb 5 12:19:02 PST 2021
ldionne requested changes to this revision.
ldionne added inline comments.
This revision now requires changes to proceed.
================
Comment at: libcxx/src/CMakeLists.txt:5-10
+if (ZOS)
+ set_source_files_properties(
+ chrono.cpp
+ PROPERTIES COMPILE_DEFINITIONS "_LARGE_TIME_API"
+ )
+endif()
----------------
ldionne wrote:
> If we're doing it this way, then why not add a `#define` at the top of `chrono.cpp`? I'd like to avoid adding complexity to the build system.
So please either use a define in `chrono.cpp` or implement my suggestion of `target_compile_definitions()`, but not this.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D93542/new/
https://reviews.llvm.org/D93542
More information about the libcxx-commits
mailing list