[libcxx-commits] [PATCH] D95848: Add `noexcept` to `string::find` and similar members.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

LGTM, please ship once CI passes. Thanks!

We should also look into marking some more `char_traits` operations as `noexcept` if they are not and if we're allowed. Otherwise, calling a non-`noexcept` function from a `noexcept` function forces the compiler to generate code that looks like:

  try { f(); } catch (...) { std::terminate(); }

which isn't great.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95848/new/

https://reviews.llvm.org/D95848