[libcxx-commits] [PATCH] D96057: [libc++] Require C++20 to build the benchmarks.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante created this revision.
Mordante added a reviewer: ldionne.
Herald added a subscriber: mgorny.
Mordante requested review of this revision.
Herald added a project: libc++.
Herald added a subscriber: libcxx-commits.
Herald added a reviewer: libc++.

Some work-in-progress patches for the format header contain benchmarks.
The format header requires C++20 to build. This is a preparation to make
it easy to add these benchmarks.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D96057

Files:
  libcxx/benchmarks/CMakeLists.txt
  libcxx/docs/ReleaseNotes.rst


Index: libcxx/docs/ReleaseNotes.rst
===================================================================
--- libcxx/docs/ReleaseNotes.rst
+++ libcxx/docs/ReleaseNotes.rst
@@ -38,7 +38,8 @@
 New Features
 ------------
 
-- ...
+- Starting with libc++13 a C++20 capable compiler is required to build the
+  libc++ benchmarks.
 
 API Changes
 -----------
Index: libcxx/benchmarks/CMakeLists.txt
===================================================================
--- libcxx/benchmarks/CMakeLists.txt
+++ libcxx/benchmarks/CMakeLists.txt
@@ -142,7 +142,7 @@
           RUNTIME_OUTPUT_DIRECTORY "${BENCHMARK_OUTPUT_DIR}"
           COMPILE_FLAGS "${BENCHMARK_TEST_LIBCXX_COMPILE_FLAGS}"
           LINK_FLAGS "${BENCHMARK_TEST_LIBCXX_LINK_FLAGS}"
-          CXX_STANDARD 17
+          CXX_STANDARD 20
           CXX_STANDARD_REQUIRED YES
           CXX_EXTENSIONS NO)
   cxx_link_system_libraries(${libcxx_target})
@@ -172,7 +172,7 @@
           INCLUDE_DIRECTORIES ""
           COMPILE_FLAGS "${BENCHMARK_TEST_NATIVE_COMPILE_FLAGS}"
           LINK_FLAGS "${BENCHMARK_TEST_NATIVE_LINK_FLAGS}"
-          CXX_STANDARD 17
+          CXX_STANDARD 20
           CXX_STANDARD_REQUIRED YES
           CXX_EXTENSIONS NO)
   endif()


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D96057.321494.patch
Type: text/x-patch
Size: 1221 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20210204/60625a34/attachment.bin>