[libcxx-commits] [PATCH] D93593: [libc++][format] Add __format_arg_store.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante planned changes to this revision.
Mordante added a subscriber: mehdi_amini.
Mordante added a comment.

Wanted to have a CI run to test some fixes, more work still needs to be done.



================
Comment at: libcxx/include/format:223
+// to support compilers with partial C++20 support.
+#ifndef _LIBCPP_HAS_NO_CONCEPTS
+
----------------
@ldionne If you agree with this approach I'll move it to D93166, which then should fix the issues @mehdi_amini has using clang 8.


================
Comment at: libcxx/test/std/utilities/format/format.arguments/format.arg/visit_format_arg.pass.cpp:51
+  std::basic_string<char_type> str =
+      static_cast<const char_type*>(MultiStringType MKSTR("abc"));
+
----------------
`MKSTR` -> `MAKE_STRING` and all other occurrences.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93593/new/

https://reviews.llvm.org/D93593