[libcxx-commits] [PATCH] D92229: [libc++] Add format check to CI
Louis Dionne via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Thu Feb 4 08:37:11 PST 2021
ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.
In D92229#2530444 <https://reviews.llvm.org/D92229#2530444>, @curdeius wrote:
> It would be cool if Buildkite -> Phabricator bridge handled the soft fails.
> See previous version https://reviews.llvm.org/D92229?id=320075. It shows CI passed, no warning or whatever, even though Format (soft-) failed, https://buildkite.com/llvm-project/libcxx-ci/builds/1171.
> Anyone knows where the code responsible for this is?
@goncharov might know.
This LGTM, I think this is a good start. We can start running that manually before we commit for now, to see what things look like. Once we're comfortable, we can move to the next level and make it mandatory.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the libcxx-commits