[libcxx-commits] [PATCH] D60368: Add bind_front function (P0356R5)
Louis Dionne via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Wed Feb 3 14:24:09 PST 2021
ldionne accepted this revision.
ldionne added a subscriber: Quuxplusone.
ldionne added a comment.
I think this looks good, but it needs to be rebased on top of `main`. `invoke` has been made constexpr by @Quuxplusone since then.
If CI passes, LGTM. Consider fixing my comment about `static_assert`, but it's non-blocking. You should also update the release target (it's not 12 anymore, but 13).
Comment at: libcxx/test/std/utilities/function.objects/func.bind_front/bind_front.pass.cpp:236
It's weird to call this inside `static_assert`, since we're already calling the whole `test()` inside `static_assert`. Is this needed at all now?
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the libcxx-commits