[libcxx-commits] [PATCH] D79555: [libc++] [P0415] [C++20] Constexpr for std::complex.

Wed Feb 3 14:18:28 PST 2021

ldionne requested changes to this revision.
ldionne added a comment.
This revision now requires changes to proceed.

Can you rebase onto `main` so that CI runs again? You'll also need to fix a few details like the `cxx2a_status` page which has changed.

================
Comment at: libcxx/include/complex:921
+complex<_Tp>
+operator/(const complex<_Tp>& __z, const complex<_Tp>& __w)
+{
----------------
I think we really need to unfork these implementations and use the same one in all standard modes. It looks like the only difference is pretty much that you're calling the `_constexpr` variations when `is_constant_evaluated()` in the C++20 version. Would it be possible to always call e.g. `__libcpp_scalbn`, and then have that function check for `is_constant_evaluated()` and use a constexpr-friendly implementation in that case?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79555/new/

https://reviews.llvm.org/D79555