[libcxx-commits] [PATCH] D94807: [libc++] Rationalize our treatment of contiguous iterators and __unwrap_iter().

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Feb 3 08:51:38 PST 2021


ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

Except for the comment nitpick, this LGTM. Please update and submit. Thanks a lot!



================
Comment at: libcxx/include/iterator:607
 
 #if _LIBCPP_STD_VER > 17
 template <class _Tp>
----------------
I think the comment at the top of `libcxx/test/libcxx/iterators/contiguous_iterators.pass.cpp` should come here instead, it helps understanding what's going on.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94807/new/

https://reviews.llvm.org/D94807



More information about the libcxx-commits mailing list