[libcxx-commits] [PATCH] D92508: [libc++] Add a CI job to test libc++ when building for 32 bit

Marek Kurdej via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Feb 3 00:53:25 PST 2021


curdeius added a comment.

FYI, https://bugs.llvm.org/show_bug.cgi?id=48939.
I think these two failing tests should be disabled on 32-bit x86.
I'm pretty sure for weak_ptr_ret.pass.cpp, cf.:

  #ifndef __arm__
    // On ARM32, structs larger than 4 bytes cannot be returned in registers.
    // Thus, weak_ptr will be passed indrectly even if it is trivial.
    assert((void*)&ret != local_addr);
  #endif

Not sure for unique_ptr_ret.pass.cpp though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92508/new/

https://reviews.llvm.org/D92508



More information about the libcxx-commits mailing list