[libcxx-commits] [PATCH] D95200: [test] Add basic _Unwind_ForcedUnwind + exception tests

Fangrui Song via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Feb 2 22:47:30 PST 2021


MaskRay added a comment.

In D95200#2538493 <https://reviews.llvm.org/D95200#2538493>, @ikudrin wrote:

> In D95200#2538388 <https://reviews.llvm.org/D95200#2538388>, @MaskRay wrote:
>
>> I am not sure libunwind's ARMEH implementation has working `_Unwind_ForcedUnwind` so looks like the best is to unsupport arm. How to do that?
>
> It looks like the function has not been implemented for Arm EHABI yet, see D89570 <https://reviews.llvm.org/D89570>.
>
> There are a number of tests in the `libcxxabi` test suite that use `#if !defined(_LIBCXXABI_ARM_EHABI)` to do some adjustments or disable the test completely.

In the absence of an ARMEH disabling directive, do this?

  #ifdef _LIBCXXABI_ARM_EHABI
  int main() {}
  #else
  ...
  #endif


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95200/new/

https://reviews.llvm.org/D95200



More information about the libcxx-commits mailing list